mono - chore: defense - space-free test checks and record manuals - #1706
Merged
Conversation
Maintainer confirmed § 5 trusted publisher / Drydock / 2FA and § 7 account 2FA plus offline recovery codes are done. Co-authored-by: Jared Wray <me@jaredwray.com>
Co-authored-by: Jared Wray <me@jaredwray.com>
jaredwray
marked this pull request as ready for review
August 24, 2026 23:48
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1706 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 3513 3513
Branches 795 808 +13
=========================================
Hits 3513 3513 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
GitHub matrix jobs were reporting "test (22)" which the ruleset cannot require. Name each leg test-22/24/26 and keep a test gate so the existing required check still reports. Co-authored-by: Jared Wray <me@jaredwray.com>
cursor
Bot
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Record maintainer-confirmed npm / 2FA manuals (defense-in-depth § 5 / § 7) and give the Node test matrix space-free check names so the branch ruleset can require them.
Status update
DEFENSE_IN_DEPTH.md: remaining § 5 / § 7 manuals →— PR #1706. Matrix checks are nowtest-22/test-24/test-26plus atestgate.Changes
SECURITY.mdfor stage-only trusted publisher, Drydock, package 2FA / no tokens, and phishing-resistant account 2FAtests.yml: matrix jobname: test-${{ matrix.node-version }}(no spaces). Gate jobtestso the current required check still reportscodecov.yml: drop the one-value matrix; job id iscodecovAfter this lands, a repo admin should re-apply
lockdown-repo.sh(never committed here) with:--required-checks "test,test-22,test-24,test-26,zizmor" --allowed-actions "pnpm/*,codecov/*,cloudflare/*"Do not pass
test (22)— the script rejects spaces.Verification
test-22,test-24,test-26)teststill exists for the current rulesetReference:
defense-in-depth-nodejs§ 4 / § 5 / § 7