Document syntax property bundles in the grimoire#804
Draft
jackfirth wants to merge 4 commits into
Draft
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Resyntax analyzed 9 files in this pull request and found no issues.
|
coverage: 94.164% (+0.05%) from 94.119% — grimoire-syntax-property-bundle into master |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Resyntax analyzed 9 files in this pull request and found no issues.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Resyntax analyzed 9 files in this pull request and found no issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
resyntax/private/syntax-property-bundleintoresyntax/grimoireand adds a draft API reference chapter.One quirk worth deciding on:
syntax-property-bundle-get-propertytreats an explicit#falsefailure result as if it were omitted (it raises), because the implementation uses(or failure-result fail). The draft documents the current behavior; a sentinel default would make#falsework like it does inhash-ref.Also noted while verifying: the
syntax-property-bundle-get-all-propertiestest is an empty stub, and the "with base-path parameter" test exercisessyntax-immediate-propertiesbut sits in thesyntax-all-propertiesblock.🤖 Generated with Claude Code