Return success from IsaacReadFilePath after a valid read - #788
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
Return success from IsaacReadFilePath after a valid read#788sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make
IsaacReadFilePath.compute()returnTrueafter successfully reading a file.The node explicitly returns
Falsefor an empty or missing path, but the successful branch currently populatesoutputs:fileContentsand then falls off the end of the function, implicitly returningNone.Python OmniGraph compute implementations in this extension use a boolean result to report compute success. Returning
Noneon the only successful path makes the node's status inconsistent with both its error paths and neighbouring nodes.Add the missing
return Trueafter a successful read and clarify the return-value docstring.Validation
True