Skip to content

Return success from IsaacReadFilePath after a valid read - #788

Open
sylvesterkaczmarek wants to merge 2 commits into
isaac-sim:developfrom
sylvesterkaczmarek:fix/read-file-path-success-return
Open

Return success from IsaacReadFilePath after a valid read#788
sylvesterkaczmarek wants to merge 2 commits into
isaac-sim:developfrom
sylvesterkaczmarek:fix/read-file-path-success-return

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Description

Make IsaacReadFilePath.compute() return True after successfully reading a file.

The node explicitly returns False for an empty or missing path, but the successful branch currently populates outputs:fileContents and then falls off the end of the function, implicitly returning None.

Python OmniGraph compute implementations in this extension use a boolean result to report compute success. Returning None on the only successful path makes the node's status inconsistent with both its error paths and neighbouring nodes.

Add the missing return True after a successful read and clarify the return-value docstring.

Validation

  • regression test reads a temporary UTF-8 file through the node implementation
  • verifies the file contents are populated
  • verifies the compute result is True
  • missing/empty-path behavior remains unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant