feat/multi provider support - #470
Open
sven-rosenzweig wants to merge 2 commits into
Open
Conversation
sven-rosenzweig
force-pushed
the
feat/multi_provider_support
branch
3 times, most recently
from
July 30, 2026 11:48
31d11c8 to
f2aed7d
Compare
sven-rosenzweig
changed the title
sven-rosenzweig
force-pushed
the
feat/multi_provider_support
branch
5 times, most recently
from
August 6, 2026 13:42
68eb544 to
b448d2a
Compare
Contributor
Author
|
Do not merge until the |
sven-rosenzweig
marked this pull request as ready for review
August 6, 2026 13:48
sven-rosenzweig
force-pushed
the
feat/multi_provider_support
branch
2 times, most recently
from
August 6, 2026 13:49
1dd9e0a to
33ea131
Compare
|
|
||
| // Provider is the driver that will be used to create & delete the interface. | ||
| Provider provider.ProviderFunc | ||
| // Provider provider.ProviderFunc |
Contributor
Author
There was a problem hiding this comment.
Leftover of my development process. No sepcific reason for this.
| ValidateSourceIP bool | ||
| Provider provider.ProvisioningProvider | ||
| Port int | ||
| // Provider provider.ProvisioningProvider |
Contributor
Author
There was a problem hiding this comment.
No specific reason.
Replace 'openconfig' with 'openconfig.networking.metal.ironcore.dev'. Signed-off-by: Sven Rosenzweig <sven.rosenzweig@sap.com>
sven-rosenzweig
force-pushed
the
feat/multi_provider_support
branch
2 times, most recently
from
August 11, 2026 09:28
205ce1c to
c176384
Compare
With this commit, we do not use the provider flag anymore. The provider func now is loaded dynamically on every reconciliation. Requires the `device.spec.provider` field to be set on every device. Signed-off-by: Sven Rosenzweig <sven.rosenzweig@sap.com>
sven-rosenzweig
force-pushed
the
feat/multi_provider_support
branch
from
August 11, 2026 09:36
c176384 to
12cc2bb
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to Multi Provider Support
With this commit, we do not use the provider flag anymore.
The provider func now is loaded dynamically on every reconciliation.
Requires the
device.spec.providerfield to be set on every device.