Bump SR Linux release to 26.7.2 - #3834
Merged
Merged
Conversation
Also: Pin the SRL release in transformation tests to avoid having transformation errors after each SRL release change
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The transformation test uses the floating :latest SR Linux tag, which contradicts “pinning” and causes _srl_version parsing to fall back to 25.3, making version-dependent transforms less reliable.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the default SR Linux container image used by the srlinux device definition, and adjusts the multiserver transformation test fixture to decouple its expected output from future SR Linux image tag changes.
Changes:
- Bump SR Linux containerlab image default from
26.7.1to26.7.2. - Override SR Linux image in the
multiserver-explicittopology test input and update expected output accordingly.
File summaries
| File | Description |
|---|---|
netsim/devices/srlinux.yml |
Bumps the default SR Linux clab.image tag to 26.7.2. |
tests/topology/input/multiserver-explicit.yml |
Adds an explicit SR Linux clab.image override for the transformation test input. |
tests/topology/expected/multiserver-explicit.yml |
Updates expected transformed node data for the SR Linux node to match the new override behavior. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| provider: clab | ||
| plugin: [ multiserver ] | ||
|
|
||
| defaults.devices.srlinux.clab.image: ghcr.io/nokia/srlinux:latest |
Comment on lines
+506
to
+510
| - 25 | ||
| - 3 | ||
| af: | ||
| ipv4: true | ||
| box: ghcr.io/nokia/srlinux:26.7.1 | ||
| box: ghcr.io/nokia/srlinux:latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also: Pin the SRL release in transformation tests to avoid having transformation errors after each SRL release change