Ensure Vagrant provider is 'libvirt' when trying to package our own boxes - #3832
Merged
Conversation
This fixes use when we are building our own vagrant boxes under WSL.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new provider-forcing behavior makes the existing “rerun vagrant box add …” failure hint misleading unless the provider is made explicit in the suggested command.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the netlab libvirt package workflow to ensure Vagrant uses the libvirt provider when importing a newly-built box, addressing provider-selection problems encountered when building boxes under WSL.
Changes:
- Forces Vagrant’s default provider to
libvirtduringvagrant box addin the libvirt packaging flow.
File summaries
| File | Description |
|---|---|
netsim/cli/libvirt/package.py |
Sets VAGRANT_DEFAULT_PROVIDER before importing the packaged Vagrant box to ensure libvirt is used. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have earlier fixed issue with
netlab downwhere you cannot specify the provider to use via CLI and must use Environment variable.This fixes use when we are building our own vagrant boxes under WSL.