Skip to content

refactor(android)!: remove deprecated APIs orphaned by @NativePlugin drop #8564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OS-ruimoreiramendes merged 1 commit into from
Aug 11, 2026
+2 −155
Merged

refactor(android)!: remove deprecated APIs orphaned by @NativePlugin drop #8564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions android/capacitor/src/main/java/com/getcapacitor/Bridge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,16 +1006,6 @@ public void saveInstanceState(Bundle outState) {
}
}

@Deprecated
@SuppressWarnings("deprecation")
public void startActivityForPluginWithResult(PluginCall call, Intent intent, int requestCode) {
Logger.debug("Starting activity for result");

pluginCallForLastActivity = call;

getActivity().startActivityForResult(intent, requestCode);
}

/**
* Check for Cordova plugins that may have registered to handle a permission
* request, and handle them if so. If not handled, false is returned.
Expand Down Expand Up @@ -1178,22 +1168,8 @@ boolean onActivityResult(int requestCode, int resultCode, Intent data) {
return false;
}

// deprecated, to be removed
PluginCall lastCall = plugin.getInstance().getSavedCall();

// If we don't have a saved last call (because our app was killed and restarted, for example),
// Then we should see if we have any saved plugin call information and generate a new,
// "dangling" plugin call (a plugin call that doesn't have a corresponding web callback)
// and then send that to the plugin
if (lastCall == null && pluginCallForLastActivity != null) {
plugin.getInstance().saveCall(pluginCallForLastActivity);
}

plugin.getInstance().handleOnActivityResult(requestCode, resultCode, data);

// Clear the plugin call we may have re-hydrated on app launch
pluginCallForLastActivity = null;

return true;
}

Expand Down
133 changes: 2 additions & 131 deletions android/capacitor/src/main/java/com/getcapacitor/Plugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,6 @@ public class Plugin {
// Reference to the PluginHandle wrapper for this Plugin
protected PluginHandle handle;

/**
* A way for plugins to quickly save a call that they will need to reference
* between activity/permissions starts/requests
*
* @deprecated store calls on the bridge using the methods
* {@link com.getcapacitor.Bridge#saveCall(PluginCall)},
* {@link com.getcapacitor.Bridge#getSavedCall(String)} and
* {@link com.getcapacitor.Bridge#releaseCall(PluginCall)}
*/
@Deprecated
protected PluginCall savedLastCall;

// Stored event listeners
private final Map<String, List<PluginCall>> eventListeners;

Expand Down Expand Up @@ -253,39 +241,6 @@ public String getAppId() {
return getContext().getPackageName();
}

/**
* Called to save a {@link PluginCall} in order to reference it
* later, such as in an activity or permissions result handler
* @deprecated use {@link Bridge#saveCall(PluginCall)}
*
* @param lastCall
*/
@Deprecated
public void saveCall(PluginCall lastCall) {
this.savedLastCall = lastCall;
}

/**
* Set the last saved call to null to free memory
* @deprecated use {@link PluginCall#release(Bridge)}
*/
@Deprecated
public void freeSavedCall() {
this.savedLastCall.release(bridge);
this.savedLastCall = null;
}

/**
* Get the last saved call, if any
* @deprecated use {@link Bridge#getSavedCall(String)}
*
* @return
*/
@Deprecated
public PluginCall getSavedCall() {
return this.savedLastCall;
}

/**
* Get the config options for this plugin.
*
Expand All @@ -296,23 +251,6 @@ public PluginConfig getConfig() {
return bridge.getConfig().getPluginConfiguration(handle.getId());
}

/**
* Check whether any of the given permissions has been defined in the AndroidManifest.xml
* @deprecated use {@link #isPermissionDeclared(String)}
*
* @param permissions
* @return
*/
@Deprecated
public boolean hasDefinedPermissions(String[] permissions) {
for (String permission : permissions) {
if (!PermissionHelper.hasDefinedPermission(getContext(), permission)) {
return false;
}
}
return true;
}

/**
* Check if all annotated permissions have been defined in the AndroidManifest.xml
* @deprecated use {@link #isPermissionDeclared(String)}
Expand Down Expand Up @@ -359,21 +297,6 @@ public boolean isPermissionDeclared(String alias) {
return false;
}

/**
* Check whether the given permission has been granted by the user
* @deprecated use {@link #getPermissionState(String)} and {@link #getPermissionStates()} to get
* the states of permissions defined on the Plugin in conjunction with the @CapacitorPlugin
* annotation. Use the Android API {@link ActivityCompat#checkSelfPermission(Context, String)}
* methods to check permissions with Android permission strings
*
* @param permission
* @return
*/
@Deprecated
public boolean hasPermission(String permission) {
return ActivityCompat.checkSelfPermission(this.getContext(), permission) == PackageManager.PERMISSION_GRANTED;
}

/**
* If the plugin annotation specified a set of permissions, this method checks if each is
* granted
Expand Down Expand Up @@ -531,31 +454,6 @@ private String[] getPermissionStringsForAliases(@NonNull String[] aliases) {
return permissionLauncher;
}

/**
* Helper for requesting a specific permission
*
* @param permission the permission to request
* @param requestCode the requestCode to use to associate the result with the plugin
* @deprecated use {@link #requestPermissionForAlias(String, PluginCall, String)} in conjunction with @CapacitorPlugin
*/
@Deprecated
public void pluginRequestPermission(String permission, int requestCode) {
ActivityCompat.requestPermissions(getActivity(), new String[] { permission }, requestCode);
}

/**
* Helper for requesting specific permissions
* @deprecated use {@link #requestPermissionForAliases(String[], PluginCall, String)} in conjunction
* with @CapacitorPlugin
*
* @param permissions the set of permissions to request
* @param requestCode the requestCode to use to associate the result with the plugin
*/
@Deprecated
public void pluginRequestPermissions(String[] permissions, int requestCode) {
ActivityCompat.requestPermissions(getActivity(), permissions, requestCode);
}

/**
* Get the permission state for the provided permission alias.
*
Expand Down Expand Up @@ -825,27 +723,15 @@ public void requestPermissions(PluginCall call) {
}

/**
* Handle request permissions result. Subclasses may override this to handle the result,
* or the default implementation will handle the result for our convenient requestPermissions call.
* Handle request permissions result. Subclasses may override this to handle the result.
* @deprecated in favor of using callbacks in conjunction with {@link CapacitorPlugin}
*
* @param requestCode
* @param permissions
* @param grantResults
*/
@Deprecated
protected void handleRequestPermissionsResult(int requestCode, String[] permissions, int[] grantResults) {
if (!hasDefinedPermissions(permissions)) {
StringBuilder builder = new StringBuilder();
builder.append("Missing the following permissions in AndroidManifest.xml:\n");
String[] missing = PermissionHelper.getUndefinedPermissions(getContext(), permissions);
for (String perm : missing) {
builder.append(perm + "\n");
}
savedLastCall.reject(builder.toString());
savedLastCall = null;
}
}
protected void handleRequestPermissionsResult(int requestCode, String[] permissions, int[] grantResults) {}

/**
* Called before the app is destroyed to give a plugin the chance to
Expand Down Expand Up @@ -948,21 +834,6 @@ public Boolean shouldOverrideLoad(Uri url) {
return null;
}

/**
* Start a new Activity.
*
* Note: This method must be used by all plugins instead of calling
* {@link Activity#startActivityForResult} as it associates the plugin with
* any resulting data from the new Activity even if this app
* is destroyed by the OS (to free up memory, for example).
* @param intent
* @param resultCode
*/
@Deprecated
protected void startActivityForResult(PluginCall call, Intent intent, int resultCode) {
bridge.startActivityForPluginWithResult(call, intent, resultCode);
}

/**
* Execute the given runnable on the Bridge's task handler
* @param runnable
Expand Down
Loading