Add date-range caveat to first_open and first_series_disengagement field descriptions#563
Merged
Merged
Conversation
…elds Append "Only events within the export job's requested date range are counted." to the description of these two export stats fields across all spec versions. - intercom/developer-docs#991
| type: integer | ||
| description: The first time the user opened this message. | ||
| description: The first time the user opened this message. Only events within | ||
| the export job's requested date range are counted. |
Contributor
There was a problem hiding this comment.
Same question as docs PR #991: the note is only on 2 of the 11 first_* fields, so the rest read as lifetime — should it cover all of them or just these two? Also the source descriptions in the monolith (app/lib/api/open_api/schemas/responses/data_export_csv.rb, lines 34 & 37) still have the old text, so spec and source will drift until those are updated too.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
anubhav-intercom
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The
first_openandfirst_series_disengagementexport stats fields were missing a key constraint: only events within the export job's requested date range are counted. Without this, developers could misinterpret the values as lifetime counts.How?
Append the clarifying sentence to both field descriptions across all versioned spec files.
Generated with Claude Code