Keep image position stable at minimum zoom - #233
Merged
Conversation
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction
When wheel zoom reaches
minScale, another zoom-out keeps the scale clamped but still changestranslateXandtranslateY. The regression test reproduces the horizontal drift from436.9pxto411.8pxat a0.95minimum.Root cause
The scale was clamped before rendering, but position updates still used the requested
zoomSpeedrather than the scale delta that was actually applied.Fix
minScale.Verification
npm run verify0.1minimum, an extra wheel zoom left the complete image transform unchangedFixes #95