refactor(napari): use the glasbey package for label LUTs#39
Merged
Conversation
Drop the custom colorcet/CyclicLabelColormap helper; instead build the palette with glasbey.create_palette (the approach from napari's gallery) and hand the list straight to add_labels(colormap=...). Lightness biased up so colours read on the dark canvas. Toggle via the `glasbey` arg. Swap the napari extra dep colorcet -> glasbey. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the napari glasbey gallery: drop the custom colorcet helper, build the palette with
glasbey.create_palette(256, lightness_bounds=(40,100))(biased lighter for the dark canvas) and pass the list straight toadd_labels(colormap=...).glasbeyarg (defaultTrue); guarded so a missing package falls back to napari's default.colorcet→glasbey.🤖 Generated with Claude Code