Added animatedLogoColumns - #36
Open
MSchak wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for imarc-pronto ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
khamer
reviewed
Sep 4, 2026
| // WCAG / ARIA carousel pattern: stop auto-rotation when focus enters the component. | ||
| // Rotation only resumes if the user clicks play. | ||
| const onFocusIn = () => { | ||
| if (!prefersReducedMotion.value) { |
Member
There was a problem hiding this comment.
Maybe if (isPlaying.value) { instead?
| } | ||
|
|
||
| onMounted(() => { | ||
| prefersReducedMotion.value = window.matchMedia('(prefers-reduced-motion: reduce)').matches |
Member
There was a problem hiding this comment.
What about adding
if (prefersReducedMotion.value) {
isPlaying.value = false
}
| import { computed, onMounted, ref } from 'vue' | ||
|
|
||
| // Accessible name for the logo group. Pass the section heading id via aria-labelledby. | ||
| const props = defineProps({ |
Member
There was a problem hiding this comment.
For the attributes that are just going to pass through, I'd just use fallthrough attributes - https://vuejs.org/guide/components/attrs.html
And you won't need to define any of these props.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an animated logo flipper with accessibility features
Takes two logos per column and animates them in a flipping manner.
Accessibility features:
aria-label + aria-describedby
srOnly static list with logo flipper hidden for easier access to content for screen readers
Prefers reduced motion:reduce sets logos to grid instead of flipping animation
Play/pause button