Skip to content

fix: set signatureChainId in recover_user_from_user_signed_action #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
massimiliano1991 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: set signatureChainId in recover_user_from_user_signed_action #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hyperliquid/utils/signing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,7 @@ def recover_agent_or_user_from_l1_action(action, signature, active_pool, nonce,


def recover_user_from_user_signed_action(action, signature, payload_types, primary_type, is_mainnet):
action["signatureChainId"] = "0x66eee"
action["hyperliquidChain"] = "Mainnet" if is_mainnet else "Testnet"
data = user_signed_payload(primary_type, payload_types, action)
structured_data = encode_typed_data(full_message=data)
Expand Down
24 changes: 24 additions & 0 deletions tests/signing_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@

from hyperliquid.exchange import _multi_sig_payload_action
from hyperliquid.utils.signing import (
USD_SEND_SIGN_TYPES,
OrderRequest,
ScheduleCancelAction,
action_hash,
construct_phantom_agent,
float_to_int_for_hashing,
order_request_to_order_wire,
order_wires_to_order_action,
recover_user_from_user_signed_action,
sign_l1_action,
sign_usd_transfer_action,
sign_withdraw_from_bridge_action,
Expand Down Expand Up @@ -288,3 +290,25 @@ def test_schedule_cancel_action():
assert signature_testnet["r"] == "0x4e4f2dbd4107c69783e251b7e1057d9f2b9d11cee213441ccfa2be63516dc5bc"
assert signature_testnet["s"] == "0x706c656b23428c8ba356d68db207e11139ede1670481a9e01ae2dfcdb0e1a678"
assert signature_testnet["v"] == 27


def test_user_signed_action_recover_roundtrip():
# Regression test: recover_user_from_user_signed_action must set signatureChainId
# symmetrically with sign_user_signed_action. A verifier reconstructs the action
# without signatureChainId, so recover has to add it -- otherwise user_signed_payload
# raises KeyError: 'signatureChainId'.
wallet = eth_account.Account.from_key("0x0123456789012345678901234567890123456789012345678901234567890123")

def fresh_action():
return {
"destination": "0x0000000000000000000000000000000000000001",
"amount": "1",
"time": 1677777606040,
}

for is_mainnet in (True, False):
signature = sign_usd_transfer_action(wallet, fresh_action(), is_mainnet)
recovered = recover_user_from_user_signed_action(
fresh_action(), signature, USD_SEND_SIGN_TYPES, "HyperliquidTransaction:UsdSend", is_mainnet
)
assert recovered == wallet.address