Skip to content

feat: support async table loads and append mode#134

Merged
hotdata-automation[bot] merged 2 commits into
mainfrom
openapi-update-28839842394
Jul 7, 2026
Merged

feat: support async table loads and append mode#134
hotdata-automation[bot] merged 2 commits into
mainfrom
openapi-update-28839842394

Conversation

@hotdata-automation

@hotdata-automation hotdata-automation Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www.hotdata.dev/pull/254

Also completes the regen by hand: results and query runs are now scoped to a database via the required X-Database-Id header, so the hand-written ergonomic layer (query.py, arrow.py) threads a database_id through the result/query-run helpers and query()'s truncation auto-follow. Without this the package's unit/integration tests fail against the regenerated signatures. Mirrors sdk-rust#84.

@hotdata-automation hotdata-automation Bot enabled auto-merge (squash) July 7, 2026 03:42
claude[bot]
claude Bot previously approved these changes Jul 7, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-generated SDK regeneration from the OpenAPI spec update. Reviewed the substantive model and API changes — new async load fields with correct ge=1000 validation, append mode, and the required x_database_id header threaded consistently through the query-runs and results APIs. Generated code is internally consistent. LGTM.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the generated OpenAPI regen and the hand-written ergonomic layer. The x_database_id threading through auto-follow (query_materialize_fullwait_for_result/_authoritative_total/_fetch_all_rows) and the arrow helpers is consistent, the header-vs-body database source fallback is sound, breaking signature changes are documented in the CHANGELOG, and both paths are covered by tests. LGTM.

@hotdata-automation hotdata-automation Bot merged commit f446d04 into main Jul 7, 2026
5 checks passed
@hotdata-automation hotdata-automation Bot deleted the openapi-update-28839842394 branch July 7, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant