fix(producer): type video extraction failures#2776
Open
jrusso1020 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
Depends on #2774 for atomic remote downloads and its single owned download retry. This PR is intentionally based on
fix/atomic-video-download-retry; rebase/change the base tomainafter #2774 merges.Default compatibility
HF_VIDEO_EXTRACTION_FAILURE_MODEdefaults tooffand forcesmaxTransientRetries=0.With the feature off:
Typed metadata aggregation is explicit and enabled only by the candidate enforce lane.
Retry ownership
HF_VIDEO_EXTRACTION_MAX_RETRIES=1The internal sidecar and Experiment Framework must treat both exhausted stage codes as workflow-terminal after the producer-local budget. Candidate enforcement must not be enabled until those companion mappings are deployed, or Temporal can multiply producer attempts.
Failure contract
VIDEO_SOURCE_UNRENDERABLE: at least one deterministic/unknown source failureVIDEO_EXTRACTION_FAILED: all source failures are transient but the producer-local budget is exhaustedOnly the allowlisted code and kind/count summaries cross JSON/SSE. Raw diagnostics remain engine-local because they may contain signed URLs or local paths.
Rollout
offobserve, retries 0observe, retries 1enforce, retries 1Validation