feat: rewrite as TanStack Start app — a clearer HyperFrames-on-Cloudflare example #10
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| check: | ||
| name: Typecheck, test, manifest freshness | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
|
Contributor
There was a problem hiding this comment. Verified rather than trusted from the comment — both pins resolve exactly to their claimed tags:
No pin/comment mismatch. With |
||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| with: | ||
| node-version: 24 | ||
| cache: npm | ||
|
|
||
| - run: npm ci | ||
|
|
||
| # Deliberately from a clean checkout, before any build step — the | ||
| # committed composition-manifest.json must be enough for tsc to pass. | ||
| - run: npm run typecheck | ||
|
|
||
| - run: npm test | ||
|
|
||
| # The manifest is committed but regenerated by prepare-assets; fail if | ||
| # a composition change landed without its manifest diff. | ||
| - run: npm run prepare-assets | ||
| - run: git diff --exit-code src/composition-manifest.json | ||
|
Contributor
There was a problem hiding this comment. Verified this step is sound and not flaky: I ran Committing the generated input so a clean checkout typechecks, then guarding staleness here, is the right shape for the problem. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top finding: this workflow has never executed on this PR, so the gate it adds is still unproven here.
pull_requestis the correct trigger (notpull_request_target) — fork code runs without repo secrets. But two things combine to mean zero runs so far: a workflow isn't registered until it lands on the default branch (the repo currently lists onlyDependabot Updates), and this PR is from a fork whose author GitHub reports asFIRST_TIME_CONTRIBUTOR, so runs need a maintainer to click "Approve and run workflows". The only check at this head is theWIPmarketplace app.Worth actually running rather than assuming, since it's this workflow's first execution:
node-version: 24is unexercised (I verified locally on Node 22), andgit diff --exit-codeon a generated file is exactly the kind of step that can differ in CI.mainisn't protected and has no required checks, so nothing mechanically blocks merging with this unverified.