Conversation
liseli
approved these changes
Jul 30, 2026
liseli
left a comment
liseli
left a comment
Contributor
There was a problem hiding this comment.
@eumalin, these changes look good to me. I've tested locally, and the JAR was successfully created.
For this JAR, it makes sense to hard code the Java, Solr, and Lucene versions in the pom.xml file because when we decide to migrate to newer versions, we'll likely need to update the source code as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Maven build system and github actions release workflow so HTPostingsFormat.jar is built and published automatically on tag push, instead of being compiled by hand. Moves source files to the standard Maven layout. Targets Lucene 9.12.3, which is what solr:9.10.1 bundles.