feat: Convert many toReadableSequentialData to toPbjReader - #918
Open
ldintr wants to merge 1 commit into
Open
Conversation
Signed-off-by: ldintr <levo.d@swirldslabs.com>
ldintr
force-pushed
the
ldintr-toPbjReader
branch
from
September 10, 2026 19:07
7d33c30 to
5251d33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out remaining spots (gRPC client PbjGrpcCall, generated ServiceGenerator dispatch, Codec.parse(Bytes)/parseStrict(Bytes)) still using Bytes.toReadableSequentialData(), switching them to Bytes.toPbjReader()/new Codec.parse(Bytes, ...) overloads. Public behavior unchanged; tests/mocks updated.
Overview: PbjReader/PbjWriter are a leaner, buffer-reusing alternative to the existing ReadableSequentialData/WritableSequentialData read/write path used by Codec, ProtoParserTools/ProtoWriterTools, and the pbj-compiler generators. They reuse an internal ~16KB (L1-cache-sized) buffer across many parse/write calls instead of allocating per call, avoid checked-exception-based control flow by recording a sticky internal error code instead, and split hot-path operations (e.g. zigzag vs. non-zigzag varints, direct UTF-8 decode into a reusable char[]) into dedicated fast methods.