[bugfix]: Restore exact Qwen3-VL vision interpolation - #1737
Conversation
There was a problem hiding this comment.
Welcome to FastVideo! Thanks for your first pull request.
How our CI works:
PRs run a two-tier CI system:
- Pre-commit — formatting (yapf), linting (ruff), type checking (mypy). Runs immediately on every PR.
- Fastcheck — core GPU tests (encoders, VAEs, transformers, kernels, unit tests). Runs automatically via Buildkite on relevant file changes (~10-15 min).
- Full Suite — integration tests, training pipelines, SSIM regression. Runs only when a reviewer adds the
readylabel.
Before your PR is reviewed:
-
pre-commit run --all-filespasses locally - You've added or updated tests for your changes
- The PR description explains what and why
If pre-commit fails, a bot comment will explain how to fix it. Fastcheck and Full Suite results appear in the Checks section below.
Useful links:
Merge Protections🔴 1 of 1 protections blocking · waiting on 👀 reviews and 🤖 CI
🔴 PR merge requirementsWaiting for
This rule is failing.
|
|
CI triage for Buildkite #4973:
This looks independent of the Qwen3-VL interpolation patch. A maintainer rerun should be sufficient for the transient encoder download failure; |
5752870 to
f20a4e0
Compare
|
Rebased this single change onto current main (2f3d407) and revalidated the focused regression with Transformers 5.15.0: python -X utf8 -m pytest fastvideo/tests/encoders/test_minimax_h3_qwen3_vl_vision.py -q -> 6 passed. The previous #4973 encoder failure was the unrelated Hugging Face connection reset described above, while #4971's encoder lane passed on the same patch. The new head f20a4e0 should trigger a clean CI run. |
|
CI update after rebasing onto current main: pre-commit passed, and the PR-relevant Buildkite Encoder Tests lane passed in 13m 9s. The only remaining red lane is the repository-wide microscope Unit Tests job. The preceding run showed those failures in unrelated ATTN-QAT, schema inventory/CI collection, and FA4 policy tests; this PR only changes the Qwen3-VL vision encoder path and its focused regression suite passes 6/6 locally. I have therefore kept this PR scoped and have not mixed unrelated unit-suite repairs into it. |
f20a4e0 to
9911ab4
Compare
9911ab4 to
0f1cc9b
Compare
|
/merge |
|
/test full |
0f1cc9b to
6ded0f7
Compare
|
/test full |
|
/merge |
Summary
Fixes #1733 by restoring exact MiniMax-H3 Qwen3-VL visual position interpolation and bounding its production memory cost.
The original contributor commit and attribution are preserved on top of current main.
Dependency contract
FastVideo still supports Transformers 5.0 and newer. The exact Transformers 5.15 interpolation contract is therefore tested through a self-contained slow reference on every supported version. When Transformers 5.15 or newer exposes the public helper, a separate cross-check proves that reference bit-exact. Older supported versions skip only that library cross-check; the exact contract and independent PyTorch interpolation gates still run.
Validation
Exact rebased head:
The standing MiniMax-H3 SSIM test is text-only T2VA and does not execute this visual-conditioning path, so no reference reseed is needed. The requested full CI graph remains the external release gate.