Add an endpoint sharing a composite modification of a node - #1070
Open
flomillot wants to merge 4 commits into
Open
Add an endpoint sharing a composite modification of a node#1070flomillot wants to merge 4 commits into
flomillot wants to merge 4 commits into
Conversation
The composite modification is moved out of the study into a directory of GridExplore, where it becomes a shared modification, and is replaced in the node by a reference to it. Since the applied modifications are left unchanged, the node does not need to be rebuilt. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
GhilesA
approved these changes
Aug 20, 2026
GhilesA
left a comment
GhilesA
left a comment
Contributor
There was a problem hiding this comment.
Just apply the sonar recommandation on QUERY_PARAM_GROUP_UUID
ghazwarhili
requested changes
Aug 20, 2026
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
ghazwarhili
reviewed
Aug 20, 2026
GhilesA
self-requested a review
August 20, 2026 12:54
ghazwarhili
reviewed
Aug 20, 2026
The network modification server does not return it anymore, the composite modification keeping its uuid when extracted. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
|
ghazwarhili
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
POST /v1/studies/{studyUuid}/nodes/{nodeUuid}/network-modifications/{modificationUuid}/share?name=&description=&parentDirectoryUuid=, which moves a composite modification of a node out of the study into a directory of GridExplore, and replaces it in the node by a reference to this now shared modification.The write permission on the target directory and the uniqueness of the name are checked before anything is moved. The composite is then extracted by the network modification server — keeping its uuid — stored as a
MODIFICATIONelement of the directory server, and referenced from the node.Since the applied modifications are left unchanged, the node is not invalidated: only the modifications update notifications are emitted, so the front refetches the list.
Requires gridsuite/network-modification-server#874.