Skip to content

add name for csv file - #270

Open
EtienneLt wants to merge 4 commits into
mainfrom
add-name-for-csv
Open

add name for csv file#270
EtienneLt wants to merge 4 commits into
mainfrom
add-name-for-csv

Conversation

@EtienneLt

Copy link
Copy Markdown
Contributor

PR Summary

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt self-assigned this Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9c2c41bd-f0f4-4be5-bda1-fa4e8707534f


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>

@Mathieu-Deharbe Mathieu-Deharbe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is fine but the ticket precise to look for the same problem in other computations and I found exactly the same problem for the shortcircuit computation.

@Parameter(description = "Sort parameters") Sort sort) {
HttpHeaders httpHeaders = new HttpHeaders();
httpHeaders.setContentType(APPLICATION_OCTET_STREAM);
httpHeaders.setContentDispositionFormData("attachment", "N-results.zip");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a constant like sonar asks :

Suggested change
httpHeaders.setContentDispositionFormData("attachment", "N-results.zip");
httpHeaders.setContentDispositionFormData(ATTACHMENT, "N-results.zip");

Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants