Skip to content

feat: use standalone Filter in assignmenents modifications - #223

Open
TheMaskedTurtle wants to merge 6 commits into
mainfrom
jorism/feat/use-filter-in-assignments
Open

feat: use standalone Filter in assignmenents modifications#223
TheMaskedTurtle wants to merge 6 commits into
mainfrom
jorism/feat/use-filter-in-assignments

Conversation

@TheMaskedTurtle

@TheMaskedTurtle TheMaskedTurtle commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

PR Summary

Starting the migration of modification so that they can really be standalone. Starting by inheritors of AbstractAssignmentModification which are ByFormulaModification and ModificationByAssignment.

For that I had to:

  • Create a new data structure that is based only on Filter interface
  • Modify dto to modification mappers to use FilterLoader and build modifications with Filter interface
  • Adapt modifications application so that it matches the new data structure
  • Adapt tests

Also, reports were not used properly towards the ReportNode interface, I adjusted that as well in the related classes.

Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d5507c9-1967-49c1-b89f-f8165b4dc042


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
@TheMaskedTurtle
TheMaskedTurtle force-pushed the jorism/feat/use-filter-in-assignments branch from 8a1e34f to 39d9fca Compare August 25, 2026 15:31
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant