feat(serde): make network modifications serializable and deserializable - #220
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
KoloMenek
changed the title
KoloMenek
marked this pull request as draft
August 13, 2026 15:48
Signed-off-by: Kamil MARUT <kamil.marut@rte-france.com>
KoloMenek
force-pushed
the
marutk/feat/make_network_modifications_serde
branch
from
August 18, 2026 07:15
8ef5a2e to
d5acc17
Compare
KoloMenek
marked this pull request as ready for review
August 18, 2026 07:16
KoloMenek
changed the title
Signed-off-by: Kamil MARUT <kamil.marut@rte-france.com>
# Conflicts: # src/main/java/org/gridsuite/modification/dto/ByFormulaModificationInfos.java # src/main/java/org/gridsuite/modification/dto/ModificationByAssignmentInfos.java # src/main/java/org/gridsuite/modification/dto/tabular/TabularModificationInfos.java # src/main/java/org/gridsuite/modification/modifications/AbstractModification.java # src/main/java/org/gridsuite/modification/modifications/BatteryCreation.java # src/main/java/org/gridsuite/modification/modifications/BatteryModification.java # src/main/java/org/gridsuite/modification/modifications/ByFilterDeletion.java # src/main/java/org/gridsuite/modification/modifications/DeleteAttachingLine.java # src/main/java/org/gridsuite/modification/modifications/DeleteVoltageLevelOnLine.java # src/main/java/org/gridsuite/modification/modifications/EquipmentAttributeModification.java # src/main/java/org/gridsuite/modification/modifications/EquipmentDeletion.java # src/main/java/org/gridsuite/modification/modifications/GenerationDispatch.java # src/main/java/org/gridsuite/modification/modifications/GeneratorCreation.java # src/main/java/org/gridsuite/modification/modifications/GeneratorModification.java # src/main/java/org/gridsuite/modification/modifications/GeneratorScaling.java # src/main/java/org/gridsuite/modification/modifications/GroovyScript.java # src/main/java/org/gridsuite/modification/modifications/LccCreation.java # src/main/java/org/gridsuite/modification/modifications/LccModification.java # src/main/java/org/gridsuite/modification/modifications/LineAttachToVoltageLevel.java # src/main/java/org/gridsuite/modification/modifications/LineCreation.java # src/main/java/org/gridsuite/modification/modifications/LineModification.java # src/main/java/org/gridsuite/modification/modifications/LineSplitWithVoltageLevel.java # src/main/java/org/gridsuite/modification/modifications/LinesAttachToSplitLines.java # src/main/java/org/gridsuite/modification/modifications/LoadCreation.java # src/main/java/org/gridsuite/modification/modifications/LoadModification.java # src/main/java/org/gridsuite/modification/modifications/LoadScaling.java # src/main/java/org/gridsuite/modification/modifications/OperatingStatusModification.java # src/main/java/org/gridsuite/modification/modifications/ShuntCompensatorCreation.java # src/main/java/org/gridsuite/modification/modifications/ShuntCompensatorModification.java # src/main/java/org/gridsuite/modification/modifications/StaticVarCompensatorCreation.java # src/main/java/org/gridsuite/modification/modifications/SubstationModification.java # src/main/java/org/gridsuite/modification/modifications/TwoWindingsTransformerCreation.java # src/main/java/org/gridsuite/modification/modifications/TwoWindingsTransformerModification.java # src/main/java/org/gridsuite/modification/modifications/VoltageInitModification.java # src/main/java/org/gridsuite/modification/modifications/VoltageLevelCreation.java # src/main/java/org/gridsuite/modification/modifications/VoltageLevelModification.java # src/main/java/org/gridsuite/modification/modifications/VscCreation.java # src/main/java/org/gridsuite/modification/modifications/VscModification.java # src/main/java/org/gridsuite/modification/modifications/byfilter/AbstractModificationByAssignment.java # src/main/java/org/gridsuite/modification/modifications/byfilter/ByFormulaModification.java # src/main/java/org/gridsuite/modification/modifications/byfilter/ModificationByAssignment.java # src/main/java/org/gridsuite/modification/modifications/tabular/TabularCreation.java # src/main/java/org/gridsuite/modification/modifications/tabular/TabularModification.java # src/test/java/org/gridsuite/modification/modifications/CompositeModificationsTest.java
Signed-off-by: Kamil MARUT <kamil.marut@rte-france.com>
…ModificationByAssignment Signed-off-by: Kamil MARUT <kamil.marut@rte-france.com>
Signed-off-by: Kamil MARUT <kamil.marut@rte-france.com>
KoloMenek
force-pushed
the
marutk/feat/make_network_modifications_serde
branch
from
August 19, 2026 08:18
0906567 to
78705fa
Compare
TheMaskedTurtle
requested changes
Aug 19, 2026
TheMaskedTurtle
left a comment
TheMaskedTurtle
left a comment
Contributor
There was a problem hiding this comment.
I think you should add @EqualsAndHashCode annotation in HvdcLccDeletionInfos file
TheMaskedTurtle
requested changes
Aug 19, 2026
Signed-off-by: Kamil MARUT <kamil.marut@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
…to handle properly deserialization Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
TheMaskedTurtle
force-pushed
the
marutk/feat/make_network_modifications_serde
branch
from
August 19, 2026 16:11
6872069 to
f1271e0
Compare
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
TheMaskedTurtle
approved these changes
Aug 20, 2026
|
SlimaneAmar
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.