Skip to content

refactor: use justify-content space-between instead of grid columns - #27

Open
TheMaskedTurtle wants to merge 22 commits into
mainfrom
jorism/new-top-bar-suggestion
Open

refactor: use justify-content space-between instead of grid columns#27
TheMaskedTurtle wants to merge 22 commits into
mainfrom
jorism/new-top-bar-suggestion

Conversation

@TheMaskedTurtle

@TheMaskedTurtle TheMaskedTurtle commented Aug 21, 2026

Copy link
Copy Markdown

PR Summary

@FranckLecuyer
In progress ...
6770970 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Merge remote-tracking branch 'origin/main' into new_top_bar
3f963bb
@FranckLecuyer
Fix grid layout configuration
94d73cc 
Fix height, column spacing ...
Change icons
Execute button use now primary coler and is variant outlined

Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Do not show tab label on small screen
2cf7c1b 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Add divider between execute button and toggle button
717d71d 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Remove unused path
bd3926c 
Add breakpoints to dark theme

Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Fix shadow appearing when the configuration mode toggle button is dis…
b1b893e 
…abled

Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Change gridMonitor app path
560c824 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Add tooltip instead of label for the tabs on small screen
6312ac0 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Removing unused userManager from top bar props
b0e58a0 
Hiding top bar content when user is not authenticated

Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Fix test
2c72eef 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Fix test
d80d835 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Fix sonar issues
0c827f3 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Fix duplicated lines issue
9746798 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Make the top bar sticky
61bd320 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Add maxHeight and minWidth for execute process button
7d7ac7a 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Add unit tests
f05d72b 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Improve code coverage
2025638 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Add test for AppTopBar
7493062 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Change icons and label
d8009a1 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@coderabbitai

coderabbitai Bot commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3400abab-3aee-4bb2-8158-725eabddc814

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate billing to continue.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TheMaskedTurtle
TheMaskedTurtle force-pushed the jorism/new-top-bar-suggestion branch from 474ba62 to f6df93b Compare August 21, 2026 09:46
@TheMaskedTurtle
refactor: use justify-content space-between instead of grid columns
60c1a00 
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
@TheMaskedTurtle
TheMaskedTurtle force-pushed the jorism/new-top-bar-suggestion branch from f6df93b to 60c1a00 Compare August 21, 2026 09:55
@FranckLecuyer
FranckLecuyer force-pushed the jorism/new-top-bar-suggestion branch from 8614a11 to ddf2fba Compare August 24, 2026 09:20
@FranckLecuyer
Simplification for the configuration mode boolean
701bf0c 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
FranckLecuyer force-pushed the jorism/new-top-bar-suggestion branch from ddf2fba to 701bf0c Compare August 24, 2026 09:26
@sonarqubecloud

sonarqubecloud Bot commented Aug 24, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@FranckLecuyer
FranckLecuyer changed the base branch from new_top_bar to main August 27, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheMaskedTurtle @FranckLecuyer