readable naming, macOS wifi-msg counting, and cleanup

[Narayana-CT]

Behaviour changes

macOS devices reported 0 for every metric. Two separate causes, both fixed.

count_wifi_msg_matches() tokenized messages with text.split(" "), which
leaves punctuation glued to the token. A macOS line reads
en0: STA is connected to a wireless network., so the port token is "en0:"
and never equals the "en0" taken from the device EID. The port gate runs
before the filter test, so every macOS message was dropped before any filter was
considered. A new tokenize_wifi_msg() splits on whitespace and colons and
strips trailing .,;, and is applied to both the message text and the match
text — normalising one side alone would break filters that carry their own
punctuation, such as "association started.".

Even with the port matching, macOS had no branch of its own. It fell through to
the linux/mac path, which matches wpa_supplicant text like
<3>CTRL-EVENT-CONNECTED that macOS never sends. Across 631 live wifi-msgs from
resource 1.29, macOS sends exactly two shapes and nothing else:

CLI argument renames ( old flags removed)

Old	New
--host	--lanforge_ip
--port	--lanforge_port
--mgr_ip	--upstream_port
--reset	--iterations
--release	--android_releases
--time_int	--reset_interval

Parser now uses allow_abbrev=False — otherwise --reset 10 was silently read
as an abbreviation of the new --reset_interval. --encryp, --dowebgui,
--passwd etc. were left alone (shared across 9+ sibling scripts).

__init__ attribute typos also fixed: total_ass_attemst → total_assoc_attempts,
total_ass_rejects → total_assoc_rejections.

---

Function renames

Old	New
get_count()	count_wifi_msg_matches()
get_time_from_wifi_msgs()	collect_device_metrics()
write_reset_csvs()	write_iteration_csvs()
aggregate_reset_dict()	aggregate_device_metrics()
generate_coordinate_csv()	write_coordinate_csv()
create_dict_csv()	write_overall_csv()
get_last_wifi_msg()	get_last_wifi_msg_timestamp()

New function added: tokenize_wifi_msg() — splits a wifi-msg string into
tokens (handles :/whitespace/trailing punctuation), replacing 6 duplicated
text.split(" ") call sites inside count_wifi_msg_matches().

---

Argument / parameter renames

Old	New
value=	wifi_messages=
keys_list=	message_keys=
device=	device_eid=
filter=	match_text=
reset_dict= / reset_count_= (locals too)	per_iteration_results=
test_dur=	test_duration=
local_dict=	device_metrics=
phn_name=	device_eid=
timee=	since_time=
reset_cnt=	iteration=
r= / port_reset_dict=	per_iteration_results= / iteration=
data= / name=	metric_totals= / image_name=
_alignmen= (typo)	_alignment=

adb_* prefix → android_*; other_* prefix → linux_mac_* throughout.

---

Local variable renames (representative — full list is large)

• local, local_2…local_5 → connected, disconnected, scanning,
  assoc_attempts, assoc_rejections (dead local_6 removed outright)
• conected_list (typo) → connected_counts
• courses / values → bar_labels / bar_totals
• fig_size → fig (it's a Figure, not a size)
• dict_ → metric_labels
• yaxis_visable (typo) → yaxis_visible
• i_df → totals_per_device (was never a DataFrame)
• df_summary → summary_df, cols → columns, stats → metrics
• client → device_eid (and the second loop's client, which held the
  suffixed name, → client_name)
• y/z → device_eid/device_index; i → iteration/index (context-dependent)
• reset_count_/reset_count → iteration_indexes/iteration_numbers
• assorej → assoc_rejections; asso_attempts → assoc_attempts
• dis/scan/asso/asso_rej/con → disconnect_total/scan_total/
  assoc_attempt_total/assoc_rejection_total/connect_total
• adb_user_name → android_user_name
• graph1/graph2 → overall_graph/client_graph
• table_1/table_2/test_setup → per_iteration_table/device_summary_table/
  client_table_df/device_summary_df (context-dependent)
• d_name/device_type/user_name/s_no → device_names/device_types/
  user_names/serial_numbers
• coordinate/angle (loop indexes) → coordinate_index/angle_index;
  coord_key/angle_key → coordinate/angle
• port_reset_img_path → port_reset_image_path; timeout → timeout_sec
• a → response; last → last_timestamp (in get_last_wifi_msg_timestamp())

Dict key renamed (both write and read sites, since it's a plain string key,
not an attribute): self.port_reset_data[...]['reset_dict'] →
self.port_reset_data[...]['per_iteration_results'].

[haricharan-candela]

Too many changes have been made to script.
What was the issue we are fixing? Could you add that jira? List out what are the changes we have done to fix that and what other/extra changes we have made to script to fix any other issues.
Thank you for all the work

[haricharan-candela]

Approving, Hoping we have done enough testing. Next time onwards only keep the PR related to fix no formatting changes also atleast near the release