lfcli_base.py: add shared resolve_port_to_ipv4() to LFCliBase

[Narayana-CT]

Summary

Adds resolve_port_to_ipv4() to LFCliBase, a shared helper that resolves a
LANforge port to its IPv4 address.

The same port-to-IP logic is currently reimplemented in roughly 15 scripts
(lf_ftp.py, lf_webpage.py, DeviceConfig.py, test_l3.py, lf_multi_traffic.py,
lf_interop_*.py, and several under real_application_tests/), each with slightly
different behaviour and error handling. This puts a single implementation on the
base class so those copies can be retired incrementally.

Behaviour

The method accepts:

• a bare port name — eth1 (shelf and resource default to 1.1)
• a full port EID — 1.1.eth1.
• an address that is already an IP — returned unchanged, with no query issued

It returns the resolved IPv4 address as a string, or None when the port cannot
be resolved — the port does not exist, is down, has no address assigned, or the
manager response is not in the expected shape. Every failure path logs the reason
before returning.

Error handling stays with the caller: the helper reports what went wrong and hands
control back, so the calling script decides whether to continue, clean up, record a
failure in its report, or stop. That keeps the decision — and the user-facing
messaging — in the script that owns the test.

Input that is empty or not a string is rejected up front and logged, so a bad
argument surfaces as a clear message rather than an attribute error deeper in.

Verification

Exercised against LANforge manager 192.168.245.117

Input	Result
eth1, eth0, eth2	resolved to the port's address
1.1.eth1	resolved to the port's address
192.168.245.233, 8.8.8.8	returned unchanged, no query issued
0.0.0.0	returned unchanged, warning logged
eth3 (admin down)	None, reason logged
eth99 (does not exist)	None, reason logged
'', None, 0, [], {}	None, reason logged
123, 1.5, ['eth1'], b'eth1'	None, reason logged

Verified CLI:

python3 lf_interop_zoom.py --duration 1
--lanforge_ip 192.168.245.117
--signin_email <zoom_email> --signin_passwd <zoom_passwd> --participants 3 --audio --video
--upstream_port <upstream_ip>/<upstream_port>
--zoom_host 1.13
--resources 1.13,1.12,1.25
--api_stats_collection --env_file .env

[greearb]

On 8/18/26 22:07, Tarun wrote: ***@***.**** commented on this pull request. ---------------------------------------------------------------------------------------------------------------------------------------------------------------- In py-json/LANforge/lfcli_base.py <#365 (comment)>: > + logger.error( + "resolve_port_to_ipv4: port '%s' resolved to %s; the port is down or has " + "no IP assigned.", port, resolved_ip) Please avoid implementation details, just try to keep generic error cause message.

It is important to give enough information in logging messages that our engineers can understand root cause. So I do not agree with the comment above. Thanks, Ben

…

— Reply to this email directly, view it on GitHub <#365?email_source=notifications&email_token=AACHNKSMNTGK5HUT45QYQ7D5KUYX3A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJWHA2TQOJVGU22M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#discussion_r3810196879>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACHNKWOIHSDZPDJ5QWI2MD5KUYX3AVCNFSNUABFKJSXA33TNF2G64TZHMYTANRQGQ3TINZQHNEXG43VMU5TKMJXHE3DAMBSGUYKC5QC>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Ben Greear ***@***.***> Candela Technologies Inc http://www.candelatech.com

[greearb]

On 8/18/26 22:05, Tarun wrote: ***@***.**** commented on this pull request. ---------------------------------------------------------------------------------------------------------------------------------------------------------------- In py-json/LANforge/lfcli_base.py <#365 (comment)>: > + logger.error( + "resolve_port_to_ipv4: /port/%s/%s/%s response is not in the expected " + "format (%s). Data received: %s", shelf, resource, port_name, e, response) Please avoid implementation details or url related info in the logging.

No, keep the details in the logging messages. Thanks, Ben

…

— Reply to this email directly, view it on GitHub <#365?email_source=notifications&email_token=AACHNKWPNCE7KSK3OO26NYL5KUYRLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJWHA2TQMRQHA42M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#discussion_r3810190413>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACHNKUT2R3JQF5R4FIL2N35KUYRLAVCNFSNUABFKJSXA33TNF2G64TZHMYTANRQGQ3TINZQHNEXG43VMU5TKMJXHE3DAMBSGUYKC5QC>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Ben Greear ***@***.***> Candela Technologies Inc http://www.candelatech.com

[tarun-candela]

LGTM! Assuming you have done enough testing.