feat(highway_3d): extend the camera bridge for touch controls#1043
Open
saleemk wants to merge 1 commit into
Open
feat(highway_3d): extend the camera bridge for touch controls#1043saleemk wants to merge 1 commit into
saleemk wants to merge 1 commit into
Conversation
Add projection zoom, normalized view offsets, and focal board anchoring to the existing opt-in camera bridge. This enables natural touch pinch and pan behavior while preserving stock framing when the bridge is inactive. Signed-off-by: saleemk <saleem@shadowforge.co.za>
Contributor
📝 WalkthroughWalkthroughThe free-camera bridge gains projection zoom, normalized view offsets, board-anchor retention, and readouts. Camera lifecycle paths reset the new state, while source-based tests cover projection updates, caching, tilt behavior, anchor safety, ownership, and cleanup. ChangesFree-camera bridge integration
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extend the existing opt-in 3D Highway camera bridge with:
projectionZoomcontrol usingPerspectiveCamera.zoomviewOffsetXandviewOffsetYThis allows touch camera consumers to provide image-style pinch zoom and pan without replacing the renderer's existing auto-framing or camera ownership.
When the resolved bridge is absent or disabled, stock framing remains in control. Existing pose fields and Camera Director behavior remain compatible.
feedpak surface
Testing
Automated:
node --check plugins/highway_3d/screen.jsnode --test tests/js/highway_3d_wide_fov.test.jsnode --test tests/js/*.test.jsManual:
Checklist
CHANGELOG.md[Unreleased]updatedgit commit -s)Summary by CodeRabbit
New Features
Bug Fixes