feat(tools): --repo flag for content_packs (host packs in any repo)#1035
feat(tools): --repo flag for content_packs (host packs in any repo)#1035mhglover wants to merge 1 commit into
Conversation
Lets a pack be published to and referenced from a repo other than the default got-feedBack/feedBack — needed to host the rig VST packs in the rig repo (where the fat .vst3 binaries already live), collapsing the cross-repo PAT problem. See got-feedBack/feedBack-plugin-rig-builder#58. --repo threads to BOTH the publish target (_publish_release) and the emitted manifest URL (vst_url/pack_url) in each branch. A pack is downloaded from whatever the manifest says, so the two must never diverge — a guard test publishes with --repo acme/widgets and asserts the manifest URL points there. Default stays got-feedBack/feedBack, so the venue path is unchanged. Signed-off-by: Matthew Harris Glover <matthew@harrisglover.com>
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Adds a
--repoflag totools/content_packs.pyso a pack can be published to — and referenced from — a repo other than the defaultgot-feedBack/feedBack.This is the core-side prerequisite for automating the opt-in VST pack publish (got-feedBack/feedBack-plugin-rig-builder#58). The fat
.vst3binaries live in the rig repo, so hosting the VST releases there (rather than core) collapses the cross-repo PAT problem — but the tool currently hardcodes the core repo for both the upload target and the emitted URLs.--repomakes the host selectable.The load-bearing detail:
--repothreads to both call sites in each branch — the publish target (_publish_release/publish) and the URL written into the manifest (vst_url/pack_url). A pack is downloaded from whatever the manifest says, so if the flag reached only one, the manifest would advertise a repo the asset was never uploaded to and every client download would 404. A guard test publishes with--repo acme/widgets(upload mocked) and asserts the emitted manifest URL points at that same repo.Default is unchanged (
got-feedBack/feedBack), so the existing venuecontent-packs.ymlpath behaves exactly as before.feedpak surface
Checklist
CHANGELOG.md[Unreleased]updated — n/a: internal build-tool flag, not user-visible.--repo-reaches-both-sites guard; existing VST + venue tests still green: 6 VST, 25 career).git commit -s)