Skip to content

feat(tools): --repo flag for content_packs (host packs in any repo)#1035

Closed
mhglover wants to merge 1 commit into
got-feedBack:mainfrom
mhglover:feat/content-packs-repo-flag
Closed

feat(tools): --repo flag for content_packs (host packs in any repo)#1035
mhglover wants to merge 1 commit into
got-feedBack:mainfrom
mhglover:feat/content-packs-repo-flag

Conversation

@mhglover

Copy link
Copy Markdown
Contributor

What

Adds a --repo flag to tools/content_packs.py so a pack can be published to — and referenced from — a repo other than the default got-feedBack/feedBack.

This is the core-side prerequisite for automating the opt-in VST pack publish (got-feedBack/feedBack-plugin-rig-builder#58). The fat .vst3 binaries live in the rig repo, so hosting the VST releases there (rather than core) collapses the cross-repo PAT problem — but the tool currently hardcodes the core repo for both the upload target and the emitted URLs. --repo makes the host selectable.

The load-bearing detail: --repo threads to both call sites in each branch — the publish target (_publish_release / publish) and the URL written into the manifest (vst_url / pack_url). A pack is downloaded from whatever the manifest says, so if the flag reached only one, the manifest would advertise a repo the asset was never uploaded to and every client download would 404. A guard test publishes with --repo acme/widgets (upload mocked) and asserts the emitted manifest URL points at that same repo.

Default is unchanged (got-feedBack/feedBack), so the existing venue content-packs.yml path behaves exactly as before.

feedpak surface

  • This PR does not change how the app reads/writes feedpaks (manifest keys, pack files, folder layout)
  • …or it does, and the spec change landed first via the FEP process

Build-tooling only (tools/content_packs.py) — no runtime, no pack format change.

Checklist

  • CHANGELOG.md [Unreleased] updated — n/a: internal build-tool flag, not user-visible.
  • Tests added/updated for new behaviour (the --repo-reaches-both-sites guard; existing VST + venue tests still green: 6 VST, 25 career).
  • Commits are DCO signed off (git commit -s)

Lets a pack be published to and referenced from a repo other than the default
got-feedBack/feedBack — needed to host the rig VST packs in the rig repo (where
the fat .vst3 binaries already live), collapsing the cross-repo PAT problem.
See got-feedBack/feedBack-plugin-rig-builder#58.

--repo threads to BOTH the publish target (_publish_release) and the emitted
manifest URL (vst_url/pack_url) in each branch. A pack is downloaded from
whatever the manifest says, so the two must never diverge — a guard test
publishes with --repo acme/widgets and asserts the manifest URL points there.
Default stays got-feedBack/feedBack, so the venue path is unchanged.

Signed-off-by: Matthew Harris Glover <matthew@harrisglover.com>
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@mhglover, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 455abdda-0aeb-45dc-9676-49c6a3b578d8

📥 Commits

Reviewing files that changed from the base of the PR and between 8297afc and a872379.

📒 Files selected for processing (2)
  • tests/test_content_packs_vst.py
  • tools/content_packs.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mhglover
mhglover marked this pull request as ready for review July 22, 2026 23:34
@mhglover mhglover closed this Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant