fix(viz): per-panel picker finds feedBackViz_* factories (3D highway missing in split screen)#15
Merged
Merged
Conversation
…ds migrated viz The viz-factory global was renamed window.slopsmithViz_<id> -> window.feedBackViz_<id> in the feedBack rename (core's main-player picker and highway_3d register under the new name). Splitscreen still gated every per-panel viz option on the old window['slopsmithViz_'+id], so migrated viz — notably the 3D highway — never appeared in the split-screen picker (the main player was unaffected). Add a dual-prefix helper (vizFactory/hasVizFactory) that resolves feedBackViz_<id> first, then the legacy slopsmithViz_<id> (core keeps it as a compat shim for third-party viz), and route all ~10 lookup sites + the window-scan rescan through it. Bump 1.10.6 -> 1.10.7 so installs cache-bust the updated screen.js. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: topkoa <topkoa@gmail.com>
Copilot stopped reviewing on behalf of
topkoa due to an error
June 24, 2026 12:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In split screen, the per-panel viz picker stopped offering migrated visualizations (the 3D highway, etc.). The main-player picker was fine.
Root cause
The viz-factory global was renamed
window.slopsmithViz_<id>→window.feedBackViz_<id>in the feedBack rename. Core's main-player picker (static/app.js) andhighway_3dboth register/look up under the new name. Splitscreen was the one laggard — it still gated every per-panel viz option onwindow['slopsmithViz_' + id], which is now alwaysundefined, so no migrated viz showed up in the split picker.Fix
Add a dual-prefix helper and route every lookup through it:
feedBackViz_<id>, falls back to the legacyslopsmithViz_<id>(core still keeps it as a compat shim for third-party viz) — so this works whether a viz migrated or not._rescanVizPluginsFromWindow(window-scan),_startVizFactoryWatchseed/tick/all-present,populateSelectfilter + watch trigger,getPanelControlsFor(panelControls override), and the three factory-instantiation paths (enterVizMode, viz restore ininitPanel, and the in-place viz switch inselect.onchange).screen.js(and the Plugin Manager sees the update).Scope / notes
slopsmithViz_name — left as-is to keep the diff focused; the helper documents the rename.node --check screen.jspasses.Test
Split screen → per-panel picker now lists the 3D highway (and other migrated viz), selecting it installs the renderer, and a saved 3D-viz panel restores on reload.