Skip to content

build: stop bundling rig_builder VST3 bundles (~650 MB)#124

Merged
byrongamatos merged 1 commit into
got-feedBack:mainfrom
mhglover:feat/rig-vst-packs
Jul 22, 2026
Merged

build: stop bundling rig_builder VST3 bundles (~650 MB)#124
byrongamatos merged 1 commit into
got-feedBack:mainfrom
mhglover:feat/rig-vst-packs

Conversation

@mhglover

Copy link
Copy Markdown
Contributor

Draft — stacked on #123 (venue packs); includes its commit until it merges. Part of the nightly-slimming effort (#122).

Strips the fat .vst3 bundles (~650 MB) from the desktop build; they download on demand, sliced to the current platform, into a writable config-dir root the plugin's loader searches.

What's here

One targeted strip in scripts/bundle-slopsmith.sh (after the plugin copy loop): removes *rig-builder/vst, keeps the plugin + its data/vst_packs.json manifest. The plugin runs without the VSTs — a first-run prompt offers the download.

Verification

Simulated bundle tree → strip lines → rig vst removed, manifest kept. ✅

Depends on

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@byrongamatos, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ee2d8a1f-8d2a-4720-a8a2-5d4cbbe17ff5

📥 Commits

Reviewing files that changed from the base of the PR and between a2e6acf and 736fc8d.

📒 Files selected for processing (1)
  • scripts/bundle-slopsmith.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Strip the fat .vst3 bundles from the desktop build; they download on demand,
sliced to the current platform, into a writable config-dir root the plugin's
loader searches (rig_builder _download_vst_pack, data/vst_packs.json). The
plugin runs without them — a first-run prompt offers the download.

Companion to the rig plugin + core slicing PRs. Part of got-feedBack#122.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Matthew Harris Glover <matthew@harrisglover.com>
@byrongamatos

Copy link
Copy Markdown
Collaborator

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@byrongamatos
byrongamatos merged commit 00653cf into got-feedBack:main Jul 22, 2026
5 checks passed
@mhglover
mhglover deleted the feat/rig-vst-packs branch July 22, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants