build: stop bundling rig_builder VST3 bundles (~650 MB)#124
Conversation
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Strip the fat .vst3 bundles from the desktop build; they download on demand, sliced to the current platform, into a writable config-dir root the plugin's loader searches (rig_builder _download_vst_pack, data/vst_packs.json). The plugin runs without them — a first-run prompt offers the download. Companion to the rig plugin + core slicing PRs. Part of got-feedBack#122. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Matthew Harris Glover <matthew@harrisglover.com>
6924ae3 to
736fc8d
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
Draft — stacked on #123 (venue packs); includes its commit until it merges. Part of the nightly-slimming effort (#122).
Strips the fat
.vst3bundles (~650 MB) from the desktop build; they download on demand, sliced to the current platform, into a writable config-dir root the plugin's loader searches.What's here
One targeted strip in
scripts/bundle-slopsmith.sh(after the plugin copy loop): removes*rig-builder/vst, keeps the plugin + itsdata/vst_packs.jsonmanifest. The plugin runs without the VSTs — a first-run prompt offers the download.Verification
Simulated bundle tree → strip lines → rig vst removed, manifest kept. ✅
Depends on
Without those, a stripped VST has nowhere to download from.