fix(skills): treat shared guidance as reference#862
Conversation
🦋 Changeset detectedLatest commit: 299b414 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the onboarding and usage documentation for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the generated skill documentation to clarify that gws-shared should be treated as reference material rather than a startup checklist for agent and sandbox environments. It replaces the previous 'PREREQUISITE' warning with a 'REFERENCE' note across all skill markdown files, introduces a new 'Agent and Sandbox Use' section, and updates the generator code and tests accordingly. No review comments were provided, so I have no feedback to offer.
|
/gemini review |
7c596ac to
299b414
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the CLI's skill generation logic to treat gws-shared as background reference material rather than a strict prerequisite. It replaces the PREREQUISITE notice with a REFERENCE notice in all generated SKILL.md files, adds a new 'Agent and Sandbox Use' section to the shared skill template, and updates the unit tests to reflect these changes. As there are no review comments, I have no feedback to provide.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the generated skill files to treat gws-shared as reference material rather than a prerequisite. It replaces the prerequisite note with a reference note advising agents not to run setup or auth commands unless explicitly requested or needed to recover from a failure. Additionally, it adds an 'Agent and Sandbox Use' section to the shared skill documentation and includes corresponding unit tests to verify these changes. There are no review comments, so no further feedback is provided.
Summary
gws-sharedis reference material rather than a required startup procedure.gws-sharedthat discourages proactive auth, setup, cache, andgenerate-skillscommands.Fixes #849
Tests
rustfmt.exe --edition 2021 --check crates/google-workspace-cli/src/generate_skills.rsgit diff --checkcargo test -p google-workspace-cli generate_skillscould not complete locally because the Windows MSVC toolchain cannot find Visual Studiolink.exein this environment.