feat(upgrade) : migrate to Maps 3D SDK 16.0.0 and update OnMap3DClickListener API - #67
Draft
LoyalAbbas wants to merge 1 commit into
Draft
LoyalAbbas wants to merge 1 commit into
LoyalAbbas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Google Maps 3D Android samples repository to Google Maps 3D SDK
16.0.0, migratingsetMap3DClickListenercallbacks to the newMap3DClickEventsignature and updating XML layout attributes frommap3d:modetomap3d:mapMode.Key Changes
1. SDK Version & Build Configuration
gradle/libs.versions.toml: BumpedplayServicesMaps3dfrom0.2.2to16.0.0.settings.gradle.kts: Enableduse_local_mavendefault for testing against local SDK artifacts.2.
OnMap3DClickListenerMigration ((event: Map3DClickEvent) -> Boolean)Migrated all
setMap3DClickListenercall sites from(location: LatLngAltitude, placeId: String?) -> Unitto(event: Map3DClickEvent) -> Boolean:maps3d-compose):GoogleMap3D.ktto unpackevent.locationandevent.placeIdfromMap3DClickEvent, invokeonPlaceClickor fall back toonMapClick, and returntruewhen handled (falseotherwise).ApiDemos,ComposeDemos,maps3d-compose-demo,PlacesUIKit3D):MapInteractionsActivityacrossApiDemos,ComposeDemos, andmaps3d-compose-demo.MarkersActivityinApiDemosto dismiss any active popover on map click and return whether a popover was dismissed.PlacesUIKit3D/MainActivity.ktto select clicked places and returntruewhenevent.placeIdis non-empty.PlaceSnippets(snippets/kotlin-appandsnippets/java-app).Maps3DSamples/ApiDemos/migration_guide.md.3. XML Layout Attribute Migration (
map3d:mode->map3d:mapMode)map3d:modeXML attribute withmap3d:mapModeacrossMap3DViewlayouts in:Maps3DSamples/ApiDemos/common/src/main/res/layout/(activity_camera_controls.xml,activity_cloud_styling.xml,activity_common_map.xml,activity_hello_map.xml,activity_map_interactions.xml)PlacesUIKit3D/src/main/res/layout/activity_main.xml.gemini/skills/android-maps3d-sdk/assets/samples/(views_java/activity_main.xml,views_kotlin/activity_main.xml)