fix(bigquery): avoid panic on idle stream shutdown - #6816
Merged
dbolduc merged 3 commits intoSep 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the BigQuery write runner to gracefully handle idle stream closures when no requests are queued, preventing panics from popping an empty response queue. It also adds a regression test to verify this behavior. The feedback suggests refactoring the conditional block using a let-else statement to return early, which simplifies the logic and aligns with the repository's style guide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6816 +/- ##
=======================================
Coverage 97.02% 97.03%
=======================================
Files 326 326
Lines 107548 107569 +21
=======================================
+ Hits 104348 104375 +27
+ Misses 3200 3194 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dbolduc
marked this pull request as ready for review
September 15, 2026 14:08
alvarowolfx
approved these changes
Sep 15, 2026
dbolduc
enabled auto-merge (squash)
September 15, 2026 14:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server always sends one response per request... but it can also end the stream in an error without any requests in the queue. We need to account for this.
Fixes #6815