Skip to content

impl(bigquery): default write retry policy - #6813

Merged
dbolduc merged 2 commits into
googleapis:mainfrom
dbolduc:impl-bigquery-write-retry-default
Sep 15, 2026
Merged

dbolduc merged 2 commits into
googleapis:mainfrom
dbolduc:impl-bigquery-write-retry-default

Conversation

@dbolduc

@dbolduc dbolduc commented Sep 15, 2026

Copy link
Copy Markdown
Member

Define the default retry policy for the Write client. We will eventually expose this.

Note that all appends are idempotent as the service offers at-least-once semantics. The policy does not need to check it, it can assume.

Part of the work for #6355

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Sep 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new retry policy for the BigQuery Storage Write API, along with comprehensive unit tests. The reviewer suggests renaming the RetryableErrors struct to WriteRetryPolicy to better align with standard Rust naming conventions and maintain consistency across the SDK.

Comment thread src/bigquery/src/write/retry_policy.rs
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.02%. Comparing base (27f8c1e) to head (d8d12ca).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6813      +/-   ##
==========================================
- Coverage   97.02%   97.02%   -0.01%     
==========================================
  Files         326      327       +1     
  Lines      107548   107624      +76     
==========================================
+ Hits       104352   104425      +73     
- Misses       3196     3199       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc
dbolduc marked this pull request as ready for review September 15, 2026 11:27
@dbolduc
dbolduc requested a review from a team as a code owner September 15, 2026 11:27
Comment thread src/bigquery/src/write/retry_policy.rs

@alvarowolfx alvarowolfx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure to add Code::Cancelled to the retry list

@dbolduc
dbolduc enabled auto-merge (squash) September 15, 2026 15:44
@dbolduc
dbolduc merged commit 5743749 into googleapis:main Sep 15, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants