impl(bigquery): default write retry policy - #6813
Merged
dbolduc merged 2 commits intoSep 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new retry policy for the BigQuery Storage Write API, along with comprehensive unit tests. The reviewer suggests renaming the RetryableErrors struct to WriteRetryPolicy to better align with standard Rust naming conventions and maintain consistency across the SDK.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6813 +/- ##
==========================================
- Coverage 97.02% 97.02% -0.01%
==========================================
Files 326 327 +1
Lines 107548 107624 +76
==========================================
+ Hits 104352 104425 +73
- Misses 3196 3199 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dbolduc
marked this pull request as ready for review
September 15, 2026 11:27
alvarowolfx
reviewed
Sep 15, 2026
alvarowolfx
approved these changes
Sep 15, 2026
alvarowolfx
left a comment
Contributor
There was a problem hiding this comment.
Just make sure to add Code::Cancelled to the retry list
dbolduc
enabled auto-merge (squash)
September 15, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define the default retry policy for the Write client. We will eventually expose this.
Note that all appends are idempotent as the service offers at-least-once semantics. The policy does not need to check it, it can assume.
Part of the work for #6355