Skip to content

impl(bigquery): multiplexing option on writer builder - #6811

Merged
dbolduc merged 2 commits into
googleapis:mainfrom
dbolduc:bq-multiplex-pr-3
Sep 15, 2026
Merged

dbolduc merged 2 commits into
googleapis:mainfrom
dbolduc:bq-multiplex-pr-3

Conversation

@dbolduc

@dbolduc dbolduc commented Sep 15, 2026

Copy link
Copy Markdown
Member

This PR adds a fluent setter on the writer builder to enable multiplexing and plumbs the options from the client builder into the client into the writer builder into the writer.

All of this is pub(crate) for now. The next PR will make them pub.

Note: we will need separate connection pools for arrow vs. proto transports, so I am only implementing arrow right now.

Note: we discussed changing the signature of .arrow().default() in the API review. I am still going to look into that, but after I get this feature done. (There is one PR after this).

Towards #6765

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Sep 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces multiplexing support for the BigQuery Arrow writer by updating WriterBuilder to accept a shared StreamPool and adding a with_multiplexing option. The Write client now manages and passes this shared pool to the builder. Feedback suggests introducing a helper function in the test module to eliminate repetitive boilerplate code when creating WriterBuilder instances across various test cases.

Comment thread src/bigquery/src/write/arrow/writer_builder.rs Outdated
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.02%. Comparing base (63e9c2a) to head (60abfea).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6811   +/-   ##
=======================================
  Coverage   97.02%   97.02%           
=======================================
  Files         326      326           
  Lines      107548   107585   +37     
=======================================
+ Hits       104350   104388   +38     
+ Misses       3198     3197    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc
dbolduc marked this pull request as ready for review September 15, 2026 05:47
@dbolduc
dbolduc requested a review from a team as a code owner September 15, 2026 05:47
@dbolduc
dbolduc merged commit ed15621 into googleapis:main Sep 15, 2026
42 checks passed
@dbolduc
dbolduc deleted the bq-multiplex-pr-3 branch September 15, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants