Skip to content

impl(pubsub): implement publish request hedging runtime #6809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
suzmue wants to merge 1 commit into from
Closed

impl(pubsub): implement publish request hedging runtime #6809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/pubsub/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ all-features = true

[dependencies]
async-trait.workspace = true
base64.workspace = true
google-cloud-auth = { workspace = true }
Comment on lines 32 to 34

@gemini-code-assist gemini-code-assist Bot Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The base64 dependency is added to Cargo.toml but is not used anywhere in the changes or the crate. We should remove it to avoid unnecessary dependency bloat and keep the build clean.

Suggested change
async-trait.workspace = true
base64.workspace = true
google-cloud-auth = { workspace = true }
async-trait.workspace = true
google-cloud-auth = { workspace = true }
References
  1. Expose Hidden Costs: Question new dependencies or patterns that add significant boilerplate for minimal gain. (link)

bytes.workspace = true
futures.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion src/pubsub/src/publisher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ mod batch;
mod client_builder;
mod constants;
mod future;
mod hedging;
mod options;
mod retry_policy;
#[allow(dead_code)]
mod token_bucket;
Loading
Loading