feat(storage): implement replay buffer for appendable upload - #6605
Open
vsharonlynn wants to merge 3 commits into
Open
vsharonlynn wants to merge 3 commits into
vsharonlynn wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new ReplayBuffer module to manage unacknowledged data chunks, trim acknowledged data, and support resending chunks upon stream reconnection. The reviewer suggested refactoring the acknowledge method to separate the loop logic and adding a safety comment explaining the invariants when slicing the chunk data.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6605 +/- ##
==========================================
- Coverage 96.72% 96.72% -0.01%
==========================================
Files 313 314 +1
Lines 101266 101438 +172
==========================================
+ Hits 97948 98112 +164
- Misses 3318 3326 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vsharonlynn
marked this pull request as ready for review
September 1, 2026 07:37
vsharonlynn
force-pushed
the
replay-foundation
branch
from
September 1, 2026 08:07
0ae57e5 to
4ccbe87
Compare
coryan
reviewed
Sep 1, 2026
joshuatants
requested changes
Sep 3, 2026
vsharonlynn
force-pushed
the
replay-foundation
branch
from
September 8, 2026 05:50
4ccbe87 to
cdefb94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #5716 .