Skip to content

fix(biqguery): fix undeclared QueryParameter wiring in QueryStatistics - #14401

Open
Neenu1995 wants to merge 3 commits into
mainfrom
fix-undeclared-query-parameter
Open

Neenu1995 wants to merge 3 commits into
mainfrom
fix-undeclared-query-parameter

Conversation

@Neenu1995

@Neenu1995 Neenu1995 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Required to fix b/557150710

@Neenu1995
Neenu1995 requested review from a team as code owners September 16, 2026 15:51

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates JobStatistics.java to populate queryParameters from the undeclared query parameters of the query statistics. A review comment points out a compilation error due to a type mismatch between the SDK model and the protobuf model, and provides a code suggestion to map the list elements using QueryParameter::fromPb along with standard formatting adjustments.

@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2026
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants