Conversation
Neenu1995
marked this pull request as draft
September 16, 2026 14:11
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces parameter type inference for BigQueryPreparedStatement by executing dry-run queries to retrieve undeclared query parameters. It also adds validation to ensure all parameters are set before execution. The review feedback highlights a compilation error in BigQueryConnection where clear() was replaced with git(), recommends handling potential exceptions when parsing SQL type names to prevent loop termination, advises removing leftover debugging print statements in production code, and suggests correcting tautological assertions in the integration tests to verify actual expected JDBC types.
Neenu1995
changed the base branch from
main
to
fix-undeclared-query-parameter
September 16, 2026 17:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes b/557150710