Skip to content

test(bigquery): add ITBigQueryTest integration tests for queryArrow - #14376

Open
jinseopkim0 wants to merge 2 commits into
feat-bigquery-arrow-clientfrom
feat-bigquery-arrow-it
Open

jinseopkim0 wants to merge 2 commits into
feat-bigquery-arrow-clientfrom
feat-bigquery-arrow-it

Conversation

@jinseopkim0

Copy link
Copy Markdown
Contributor

This PR adds integration tests verifying the queryArrow client API against the live BigQuery service.

It tests single-page and multi-page Arrow stream consumption, validating row counts and VectorSchemaRoot iteration over live queries.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces integration tests to verify query results in Arrow format using ArrowQueryResult. The feedback recommends optimizing resource usage by utilizing the shared static bigquery client instance instead of instantiating a new RemoteBigQueryHelper and BigQuery client for each test method.

@jinseopkim0
jinseopkim0 force-pushed the feat-bigquery-arrow-it branch from 73d9458 to 4d1e4ee Compare September 14, 2026 21:03
@jinseopkim0
jinseopkim0 added this pull request to stack #14379 September 14, 2026 21:12
@jinseopkim0

Copy link
Copy Markdown
Contributor Author

@gemini-code-assist review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces integration tests for the Arrow query results format in ITBigQueryTest.java. It adds two new test cases, testQueryResultsFormatArrow and testQueryResultsFormatArrowMultiPage, to verify that querying with QueryResultsFormat.ARROW works correctly for both single-page and multi-page results using ArrowQueryResult and VectorSchemaRoot. I have no feedback to provide.

@jinseopkim0
jinseopkim0 marked this pull request as ready for review September 14, 2026 21:27
@jinseopkim0
jinseopkim0 requested review from a team as code owners September 14, 2026 21:27
@jinseopkim0
jinseopkim0 requested a review from lqiu96 September 14, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant