Conversation
whowes
added this pull request to stack #14327
September 9, 2026 06:35
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
whowes
force-pushed
the
whowes/generator-resumable-upload-stub-composer
branch
from
September 9, 2026 15:50
f246196 to
1885bb8
Compare
whowes
force-pushed
the
whowes/generator-resumable-upload-stub-composer
branch
from
September 9, 2026 20:16
1885bb8 to
542f6e7
Compare
whowes
removed this pull request from stack #14327
September 9, 2026 23:45
whowes
added this pull request to stack #14343
September 9, 2026 23:47
whowes
force-pushed
the
whowes/generator-resumable-upload-stub-composer
branch
from
September 9, 2026 23:51
542f6e7 to
6f00489
Compare
whowes
force-pushed
the
whowes/generator-resumable-upload-stub-composer
branch
from
September 10, 2026 00:19
6f00489 to
296ed15
Compare
whowes
force-pushed
the
whowes/generator-resumable-upload-stub-composer
branch
from
September 10, 2026 01:15
296ed15 to
bbc408e
Compare
whowes
force-pushed
the
whowes/generator-resumable-upload-stub-composer
branch
from
September 10, 2026 06:05
bbc408e to
c8c1e06
Compare
whowes
force-pushed
the
whowes/generator-resumable-upload-stub-composer
branch
from
September 11, 2026 17:24
c8c1e06 to
c41b295
Compare
whowes
removed this pull request from stack #14343
September 11, 2026 17:25
whowes
added this pull request to stack #14363
September 11, 2026 17:25
whowes
force-pushed
the
whowes/generator-resumable-upload-stub-composer
branch
from
September 11, 2026 18:30
c41b295 to
63a3b57
Compare
whowes
force-pushed
the
whowes/generator-resumable-upload-stub-composer
branch
from
September 11, 2026 20:00
63a3b57 to
f014476
Compare
whowes
force-pushed
the
whowes/generator-resumable-upload-stub-composer
branch
from
September 11, 2026 21:14
f014476 to
46d6fdf
Compare
whowes
force-pushed
the
whowes/generator-resumable-upload-stub-composer
branch
from
September 11, 2026 21:39
46d6fdf to
2525926
Compare
whowes
force-pushed
the
whowes/generator-resumable-upload-stub-composer
branch
from
September 11, 2026 22:15
2525926 to
2f42f31
Compare
whowes
force-pushed
the
whowes/generator-resumable-upload-stub-composer
branch
from
September 14, 2026 21:34
2f42f31 to
15511ad
Compare
blakeli0
reviewed
Sep 14, 2026
| new HttpJsonServiceResumableUploadStubClassComposer(); | ||
|
|
||
| private static final Statement EMPTY_LINE_STATEMENT = EmptyLineStatement.create(); | ||
| private static final String RESUMABLE_UPLOAD_PATH_PREFIX = "resumable/upload"; |
Contributor
There was a problem hiding this comment.
Is this hardcoded for Ads/Showcase?
| import org.jspecify.annotations.NullMarked; | ||
|
|
||
| @NullMarked | ||
| public class HttpJsonServiceResumableUploadStubClassComposer implements ClassComposer { |
Contributor
There was a problem hiding this comment.
Is it possible to extend from AbstractTransportServiceStubClassComposer? Generation logics for methods like close, shutdown should be able to be reused.
| public class HttpJsonResumableUploadServiceResumableUploadStub implements BackgroundResource { | ||
| private static final TypeRegistry typeRegistry = TypeRegistry.newBuilder().build(); | ||
|
|
||
| private static final ApiMethodDescriptor<UploadMediaRequest, UploadMediaResponse> |
Contributor
There was a problem hiding this comment.
IIRC, the ApiMethodDescriptor here is only used for startUpload?
whowes
removed this pull request from stack #14363
September 14, 2026 22:18
whowes
added this pull request to stack #14381
September 14, 2026 22:19
whowes
removed this pull request from stack #14381
September 14, 2026 23:13
whowes
added this pull request to stack #14382
September 14, 2026 23:14
Add HttpJsonServiceResumableUploadStubClassComposer to generate dedicated REST stub classes (HttpJson[Service]ResumableUploadStub) for services containing resumable upload RPC methods.
whowes
force-pushed
the
whowes/generator-resumable-upload-stub-composer
branch
from
September 15, 2026 00:43
15511ad to
ec75b25
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
HttpJsonServiceResumableUploadStubClassComposerto emit an internal, dedicated REST stub (HttpJson[Service]ResumableUploadStub) for the resumable upload protocol. The composer is registered in the generator pipeline and includes unit goldens locking in the generated stub class.