Skip to content

chore(hermetic_build): remove obsolete pom, clirr, and license headers logic from owlbot#13634

Merged
JoeWang1127 merged 1 commit into
mainfrom
rm-hermetic-code-keep-synthtool
Jul 6, 2026
Merged

chore(hermetic_build): remove obsolete pom, clirr, and license headers logic from owlbot#13634
JoeWang1127 merged 1 commit into
mainfrom
rm-hermetic-code-keep-synthtool

Conversation

@zhumin8

@zhumin8 zhumin8 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Removes the related custom Python scripts, Jinja templates, and test fixtures from the hermetic build OwlBot codebase. This is a cleanup since clirr, pom.xml generation, and license headers are now handled by Librarian.

- Deleted:
  - `fix_poms.py`
  - `fix-license-headers.py`
  - `write_clirr_ignore.sh`
  - `compare_poms.py`
  - Unused templates under `templates/clirr` and `templates/poms`
  - Unused unit tests and test fixtures
- Modified:
  - `entrypoint.sh` to remove execution steps for deleted scripts
  - `setup.py` to clean up package_data listings

Fixes googleapis/librarian#5237

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the OwlBot POM fixing, Clirr ignore generation, and license header fixing functionalities from the library generation pipeline. This includes deleting scripts like fix_poms.py, write_clirr_ignore.sh, and fix-license-headers.py, along with their associated Jinja templates, tests, and test resources. The entrypoint.sh and setup.py files have been updated to reflect these removals. There are no review comments provided, so I have no additional feedback.

@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

@zhumin8 zhumin8 marked this pull request as ready for review July 1, 2026 21:11
@zhumin8 zhumin8 requested review from a team as code owners July 1, 2026 21:11
@zhumin8

zhumin8 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Out of cautious, manually triggered generate workflow on this change: https://github.com/googleapis/google-cloud-java/actions/runs/28545135552/job/84628424599

@JoeWang1127 JoeWang1127 merged commit affdc9c into main Jul 6, 2026
222 of 227 checks passed
@JoeWang1127 JoeWang1127 deleted the rm-hermetic-code-keep-synthtool branch July 6, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

java: remove hermetic build source code

4 participants