fix(bigquery-jdbc): correct FilterTablesOnDefaultDataset fallback logic#13625
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors metadata retrieval methods in BigQueryDatabaseMetaData.java. In getTables and getColumns, empty checks are now performed on the raw input parameters before determining effective identifiers. Additionally, the logic in determineEffectiveCatalogAndSchema has been updated to use the resolved effective identifiers instead of raw parameters, and effectiveCatalog is set to null (rather than the default project) when the catalog is unspecified. I have no further feedback to provide.
Neenu1995
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/530193573
This PR fixes two compliance issues with how the driver handles JDBC metadata when
FilterTablesOnDefaultDataset=1is enabled:determineEffectiveCatalogAndSchemato strictly follow the specification matrix."") no longer incorrectly trigger the fallback."%") correctly trigger the fallback alongsidenull.effectiveCatalogtonull, ensuring the driver correctly searches for the specified dataset across all accessible projects rather than incorrectly restricting to the default project..isEmpty()checks ingetTables()andgetColumns()to the very top of the methods.