Refactor LoadTestAction for usability - #3192
Conversation
weiminyu
left a comment
There was a problem hiding this comment.
@weiminyu resolved 1 discussion.
Reviewable status: 0 of 2 files reviewed, all discussions resolved.
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 2 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on CydeWeys and weiminyu).
core/src/main/java/google/registry/loadtest/LoadTestAction.java line 163 at r3 (raw file):
private int eppTaskCount() { return successfulDomainCreatesPerSecond
why add successfulDomainCreatesPerSecond again here?
oh, is it because we create hosts? maybe worth a comment here saying that
core/src/main/java/google/registry/loadtest/LoadTestAction.java line 324 at r3 (raw file):
// lgtm[java/local-variable-is-never-read] Suppress Github CodeQL's outdated warning var _ = executorService.submit(
should we check the future results just in case the submission fails for some reason?
core/src/main/java/google/registry/loadtest/LoadTestModule.java line 46 at r3 (raw file):
return extractOptionalIntParameter(req, "delaySeconds").orElse(60); }
entirely optional: there are still contact-provider methods in this class. We can obviously remove those. No big deal either way.
weiminyu
left a comment
There was a problem hiding this comment.
@weiminyu made 3 comments.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on CydeWeys and gbrodman).
core/src/main/java/google/registry/loadtest/LoadTestAction.java line 163 at r3 (raw file):
Previously, gbrodman wrote…
why add successfulDomainCreatesPerSecond again here?
oh, is it because we create hosts? maybe worth a comment here saying that
Done.
core/src/main/java/google/registry/loadtest/LoadTestAction.java line 324 at r3 (raw file):
Previously, gbrodman wrote…
should we check the future results just in case the submission fails for some reason?
Added an explanation
core/src/main/java/google/registry/loadtest/LoadTestModule.java line 46 at r3 (raw file):
Previously, gbrodman wrote…
entirely optional: there are still contact-provider methods in this class. We can obviously remove those. No big deal either way.
Done
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on CydeWeys).
Calculates the delay seconds automatically. This value helps ensure that all EPP requests are enqueued before the scheduled test start time. Since queue insertion is much slower than dispatch, this is essential to maintain a stable QPS rate. Also parallelizes queue insertion using a thread pool. This reduces the delay for enqueuing the requests. BUG=http://b/533414332
Calculates the delay seconds automatically. This value helps ensure that all EPP requests are enqueued before the scheduled test start time. Since queue insertion is much slower than dispatch, this is essential to maintain a stable QPS rate.
Also parallelizes queue insertion using a thread pool. This reduces the delay for enqueuing the requests.
BUG=http://b/533414332
This change is