Fix std.base64 for Unicode strings - #899
Open
sb123sb123 wants to merge 1 commit into
Open
sb123sb123 wants to merge 1 commit into
sb123sb123 wants to merge 1 commit into
Conversation
Encode string inputs as UTF-8 bytes before Base64 encoding. Fixes google#887 Signed-off-by: sb123sb123 <152394158+sb123sb123@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
std.base64 rejected string inputs containing Unicode code points above 255 before encoding them. Emoji, CJK, and other non-Latin strings therefore failed instead of being encoded as UTF-8 bytes.
Fixes #887
Fix
String inputs are now passed directly through their UTF-8 byte representation before Base64 encoding. Array inputs retain their existing integer and byte-range validation.
Tests
Limitations
The complete golden test suite was also attempted on the required remote Windows Git Bash environment. Its pre-existing platform-sensitive golden expectations differ in Windows path separators and checkout line endings, so that suite reports unrelated failures; the focused regression and all-package compilation pass.
OpenAI Codex AI assistance disclosure
This pull request was prepared with OpenAI Codex AI assistance. Codex assisted with issue triage, reproduction, implementation, testing, and PR preparation; the submitting user reviewed the resulting changes.