[bot] Merge master/b145e1a3 into rel/dev - #1814
Merged
Merged
Conversation
The effort comparison in gdc-nas reads these. A pass/fail bit cannot separate two reasoning efforts, while the step count moves with the effort, and the turn count tells a wrong answer from a run max_iterations cut short. alert_skill and kda_skill gained the counters; metric_skill and conversation already had them and only needed the write. conversation also logs clarification_turns, since its total includes the turns its fixture asks for. The tests cover the counters on every skill and assert the counts reach Langfuse — the dataclass fields alone would pass with the score writes deleted.
Review nit on alert_skill: these are counts, and a float reads as though a fraction of a turn or of a reasoning step were possible. conversation already counted its clarification turns as int. Applied to every skill, including the two fields visualization and metric_skill already had — leaving those as float would have split the same two score names across two types. Test literals drop the .0, and one score test pins the type with isinstance: `2 == 2.0` is True, so the literals alone would not catch a regression.
feat(gooddata-eval): record the turns and steps each agentic run took
yenkins-admin
requested review from
hkad98,
lupko and
pcerny
as code owners
September 15, 2026 12:09
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1814 +/- ##
===========================================
+ Coverage 82.30% 82.49% +0.19%
===========================================
Files 283 283
Lines 20421 20448 +27
===========================================
+ Hits 16807 16869 +62
+ Misses 3614 3579 -35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to b145e1a (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/34967122190).