[bot] Merge master/ebca7d93 into rel/dev - #1792
Merged
Merged
Conversation
metadata-api splits its shared LDM object permission DTOs into one family per grantable resource type (gdc-nas #26771), so the four LdmObjectPermissions* schemas become twelve Attribute/Label/Fact ones. The attribute, label and fact endpoints no longer share request and response models. schemas/gooddata-metadata-client.json is patched rather than downloaded: no backend serves the new shape yet. The patch deletes the four schemas, inserts the twelve verbatim from metadata-api's open-api-spec.json, and repoints the refs in the six operations -- the only places the deleted schemas were referenced. Everything else is `make api-client-local` output, generated with jq 1.7 so that number literals are preserved. One collateral rename: DeclarativeAnalyticalDashboardPermissionForAssigneeRuleAllOf is gone. The generator materialises each inline allOf member as a class, reuses one class across parents whose member is identical, and names it after the first such parent in the alphabetically sorted schema map. AttributePermissionsForAssigneeRule now sorts ahead of the dashboard schema, so the shared class is AttributePermissionsForAssigneeRuleAllOf -- same shape, and the dashboard model still composes it. The dashboard and metric permission models change by that one import only. Depends on gdc-nas #26771 and must not merge before it. JIRA: F1-2851 risk: low Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
refactor(gooddata-api-client): split LDM object permissions per family
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1792 +/- ##
========================================
Coverage 81.86% 81.86%
========================================
Files 277 277
Lines 20016 20016
========================================
Hits 16387 16387
Misses 3629 3629 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to ebca7d9 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/34360556161).