Skip to content

[bot] Merge master/bf5c1b6d into rel/dev - #1790

Merged
yenkins-admin merged 2 commits into
rel/devfrom
snapshot-master-bf5c1b6d-to-rel/dev
Sep 9, 2026
Merged

yenkins-admin merged 2 commits into
rel/devfrom
snapshot-master-bf5c1b6d-to-rel/dev

Conversation

@yenkins-admin

Copy link
Copy Markdown
Contributor

🚀 Automated PR to perform merge from master into rel/dev with changes up to bf5c1b6 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/34350420189).

myhoai and others added 2 commits September 9, 2026 13:58
Capture every multipart response part, not just text/visualization/
alertProposal, and render them into what the judge and the simulated user
see. Normalize whitespace around MAQL punctuation before comparing, in one
shared module the agentic and non-agentic metric comparators both use, and
keep quoted literals out of every rewrite. Read the fixture's anomaly
granularity, assert it, and stop telling the simulated user to refuse one,
which deadlocked ANOMALY alert items.

jira: QA-29230
risk: low
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
fix(gooddata-eval): three false-negative sources in eval scoring
@yenkins-admin
yenkins-admin merged commit 59de414 into rel/dev Sep 9, 2026
1 check passed
@yenkins-admin
yenkins-admin deleted the snapshot-master-bf5c1b6d-to-rel/dev branch September 9, 2026 12:20
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.16867% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.86%. Comparing base (4828198) to head (bf5c1b6).
⚠️ Report is 578 commits behind head on rel/dev.

Files with missing lines Patch % Lines
...ta-eval/src/gooddata_eval/core/evaluators/_maql.py 84.48% 9 Missing ⚠️
...eval/src/gooddata_eval/core/agentic/alert_skill.py 94.11% 1 Missing ⚠️
...val/src/gooddata_eval/core/agentic/conversation.py 80.00% 1 Missing ⚠️
...val/src/gooddata_eval/core/agentic/metric_skill.py 83.33% 1 Missing ⚠️
...ata-eval/src/gooddata_eval/core/chat/sse_client.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           rel/dev    #1790      +/-   ##
===========================================
+ Coverage    81.76%   81.86%   +0.10%     
===========================================
  Files          275      277       +2     
  Lines        19903    20016     +113     
===========================================
+ Hits         16273    16387     +114     
+ Misses        3630     3629       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants