Wrap extensions with registry and add additional sec scanners#71
Merged
Conversation
wcole1-godaddy
approved these changes
Jun 24, 2026
wcole1-godaddy
left a comment
Contributor
There was a problem hiding this comment.
Approved after re-review. Local verification passed after the follow-up fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new security rule to block UI extensions from escaping their container and accessing page-level DOM, storage, or navigation APIs. It implements both source-level (
SEC012) and bundle-level (SEC112) rules to prevent unsafe operations in checkout/embed UI extensions. Additionally, it updates the extension bundling process to wrap certain UI extensions in a runtime contract, and makes minor improvements and refactoring to related code.Security: DOM Escape Operation Blocking
SEC012source rule andSEC112bundle rule to block UI extensions from accessing page-level DOM, navigation, or browser storage APIs. These rules prevent extensions from escaping the host-provided container, both in source and in the final bundle. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Bundler: UI Extension Runtime Wrapper
mountfunction and register with the global runtime. This helps enforce the container boundary at runtime. [1] [2]Type and Interface Improvements
typeproperty onReleaseUiExtensionto use theExtensionTypetype for stronger typing and clarity.These changes significantly strengthen the security posture for UI extensions by enforcing strict boundaries and preventing unsafe DOM or browser API access, both at the source and bundle level.