fix(go): resolve suffixed enum names through naming#3086
Merged
Conversation
Generated-output differences1 files differ — 0 modified, 1 new, 0 deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an opt-in
--enum-type-name-suffixGo renderer option, off by default, to make independently generated enums safe to combine in one package when their members overlap.Unlike #3085, this derives each complete constant identifier with
DependencyNameduring quicktype's naming pass instead of appending the enum name while emitting text. That lets the existing package-global namespace detect collisions involving the final identifier. For example, ifBarkDogNoiseis already a generated type, the naming pass can rename the enum constant rather than emit invalid Go with twoBarkDogNoisedeclarations.For #2624, enabling the option produces constants such as:
Tests
BARKmemberenum.schemato Go'squickTestRendererOptionswithenum-type-name-suffix=true, so QUICKTEST generates and compiles qualified enum constants.Commands run locally: