refactor(compute-providers): share EC2 runner operations - #5301
Open
edersonbrilhante wants to merge 4 commits into
Open
refactor(compute-providers): share EC2 runner operations#5301edersonbrilhante wants to merge 4 commits into
edersonbrilhante wants to merge 4 commits into
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves shared EC2 runner operations and types out of the control-plane directory so they can be reused by multiple orchestration providers.
RunnerSourceis required at the caller boundary, preserving the existingscale-up-lambdaandpool-lambdavalues, and both EC2 launch paths use that source forghr:created_by.Introduces an
Ec2RunnerClientthat owns the durable EC2 and SSM clients. Callers bind request state withforRequest({ signal }), allowing the module-scoped control-plane provider to reuse AWS clients across warm Lambda invocations without sharing cancellation state between invocations. The bound operations are passed through scale-up, scale-down, pool, runner configuration, and dynamic-label launch-template lookup instead of using a dependency bag or parameter callback.AMI values read from SSM are requested with decryption, validated as EC2 AMI IDs, and never logged.
Test Plan
git diff --checkand pre-commit checks passed.Related Issues
None.